(PUP-1751) Fix service provider on Suse to handle boot services. #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation passes the '--check' flag to chkconfig for Suse OS family. This causes chkconfig to exit with 0 when the service is enabled and non-zero when the service is disabled or non-existent. However, for boot services (services that start with 'boot.'), chkconfig is returning 0 even if the service is disabled or non-existent. The fix is to stop passing the '--check' flag to chkconfig and instead parse the output looking for '<service_name> on' to see if the service is enabled.
Add spec examples for when a service is enabled, disabled, or non-existent on a Suse OS. Remove example that expected the '--check' flag for Suse, as it is no longer passed.
|
CLA signed by all contributors. |
peterhuene
added a commit
that referenced
this pull request
Mar 19, 2014
(PUP-1751) Fix service provider on Suse to handle boot services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation passes the '--check' flag to chkconfig for
Suse OS family. This causes chkconfig to exit with 0 when the service is
enabled and non-zero when the service is disabled or non-existent.
However, for boot services (services that start with 'boot.'), chkconfig
is returning 0 even if the service is disabled or non-existent.
The fix is to stop passing the '--check' flag to chkconfig and instead
parse the output looking for '<service_name> on' to see if the service
is enabled.