(PUP-2388) Puppet acceptance for Ruby 2 x64 #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on Facter acceptance against Ruby 2. |
|
CLA signed by all contributors. |
Iristyle
changed the title
|
@Iristyle - For Ruby x86 and x64 builds via a Jenkins matrix, you'll also need to modify # If the platform is Windows, append $ruby_arch
if [[ "${platform}" =~ 'win' ]]; then
platform="${platform}-${ruby_arch}"
fi
cat > local_options.rb <<-EOF
{
:hosts_file => 'config/nodes/${platform}.yaml',
:ssh => {
:keys => ["${HOME}/.ssh/id_rsa-old.private"],
},
${repo_proxy}
}
EOF |
- Select puppet-win32-ruby branch based on the :ruby_arch host variable - Apply permissions a little differently based on how file paths are setup in the newer Ruby 2 builds - Note that at this time, the puppet-win32-ruby build for x64 does not work on Windows 2003 x64 due to 2 missing functions in MSVCRT on that platform - YAML job definitions are updated in subsequent commit
- Ensure that there are single YAML files per job type, which allows
for a more granular selection of node definitions through Jenkins.
NOTE: by using job definitions that are laid out horizontally
(by file), rather than adding multiple node definitions to a single
YAML file, this allows for better parallel execution of the suite.
Agent requests are presently serialized within Beaker when all agent
definitions occur within a single YAML configuration.
- In that vein, trash these (though Git may show some as renamed):
win2003-all.yaml
win2008-all.yaml
win2012-all.yaml
windows-all.yaml
- Spec out all valid combinations of 2003, 2003R2, 2008, 2008R2, 2012
and 2012R2 with Ruby x86 and Ruby x64 where applicable, depending
on what the platform supports.
- Not all of these configurations will be used, but keep all of the
definitions for the sake of local testing / maintaining a valid list
of operating systems where Puppet could be run on Windows.
- Note that FILECOUNT was also removed as a Beaker option where it was
defined, since it is a deprecated option.
- Note that at this time, the puppet-win32-ruby build for x64 does not
work on Windows 2003 x64 due to 2 missing functions in MSVCRT on that
platform
|
This passed through Jenkins CI successfully last night and can be merged after the job changes have been copied over from the temporary job... hurray! |
ferventcoder
added a commit
that referenced
this pull request
Jul 29, 2014
…acceptance-Ruby-2 (PUP-2388) Puppet acceptance for Ruby 2 x64
|
Woot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.