Issue/pup 2349/deprecate non string modes on file type #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
|
@kylog the failures in travis seem legitimate in so far as they are not happening only there (I'm getting them locally too). Is it possible to issue this deprecation if the The commit messages also need to be expanded to provide information about why this change is needed and why this is the right implementation. |
added 3 commits
August 15, 2014 12:02
Previously there was logic to convert incoming mode using to_i, but if it were a String that would convert the string as decimal, whereas mode is always specified as octal. I don't know why the to_i conversion was in there and whether it ever worked in a meaningful way. So fix this to convert Strings as octal.
Previously, mode was specified in some places as a Fixnum, in others as a String. Consistently specify mode as a string containing octal.
The 'future' (4.x) parser treats literal numbers as actual numbers instead of strings as the 3.x parser did. This makes file resources that use unquoted mode values behave strangely (see PUP-2156) so we are deprecating non-String values for mode. So this change adds a deprecation warning for non-String values of mode when running with --parser future.
|
Re-submitting this. Travis should be green. Since |
adrienthebo
added a commit
that referenced
this pull request
Aug 18, 2014
…ng-modes-on-file-type Issue/pup 2349/deprecate non string modes on file type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.