Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCUMENT-318) Add note about unless taking arrays #3799

Merged

Conversation

petems
Copy link
Contributor

@petems petems commented Apr 8, 2015

No description provided.

@melissa melissa added the PL label Apr 8, 2015
@puppetcla
Copy link

CLA signed by all contributors.

@kylog
Copy link

kylog commented May 19, 2015

@peterhuene @melissa: I just noticed this PR. It hasn't been covered in PR triage because it has the 'PL' label, but @petems isn't on a team that merges to puppet despite working at PL :)

Should we drop the PL label from this (and #3800) and/or treat these as part of PR triage?

@melissa melissa removed the PL label May 19, 2015
@melissa
Copy link
Contributor

melissa commented May 19, 2015

@kylog oops, that was my mistake. Thanks for catching it! I say we do what you suggest.

@peterhuene
Copy link
Contributor

@petems Would you mind terribly amending the commit message to be prefixed with (docs) for this one? Sorry this fell off our radar. I'd like to get this merged in.

@petems
Copy link
Contributor Author

petems commented May 21, 2015

@peterhuene Done! 👍

@petems petems force-pushed the DOCUMENT-318-add_unless_array_note branch from 0c0c400 to ab3ad27 Compare May 21, 2015 19:17
peterhuene added a commit that referenced this pull request May 26, 2015
@peterhuene peterhuene merged commit c82dc81 into puppetlabs:master May 26, 2015
@joshcooper
Copy link
Contributor

for future reference, just made sense it was "all" commands need to return non-zero exit codes:

0 ~/work/puppet (stable)  $ be puppet apply -e 'exec { "echo oh no": path => $path, unless => ["/usr/bin/false","/usr/bin/true"] }'
Notice: Compiled catalog for arcturus.corp.puppetlabs.net in environment production in 0.43 seconds
Notice: Applied catalog in 0.04 seconds

vs

0 ~/work/puppet (stable)  $ be puppet apply -e 'exec { "echo oh no": path => $path, unless => ["/usr/bin/false","/usr/bin/false"] }'
Notice: Compiled catalog for arcturus.corp.puppetlabs.net in environment production in 0.43 seconds
Notice: /Stage[main]/Main/Exec[echo oh no]/returns: executed successfully
Notice: Applied catalog in 0.05 seconds 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants