(PUP-4499) and (PUP-4500) Issues with TypeCalculator.common_type and String #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type calculator incorrectly assumes that the size_type of two PStringType instances should be dropped when computing a common type. This commit changes this so that the size_type will be the common type of the size_types of the given string types provided that both have a size_type defined.
…values Two String types that are not assignable in any direction, where one of the types have a set of values defined but the other one doesn't will yield a common type where values is equal to the set of the former. This commit ensures that the values set is empty if one of the given types have an empty set of values.
|
CLA signed by all contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems with the
TypeCalculator.common_typewhen used to compute the common type for twoPStringTypeinstances. I chose to put them in the same PR since they touches on the exact same lines of code which inevitably would cause merge conflicts.