(PUP-4847) Reset Facter after changing $LOAD_PATH #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2015 09:31
Facters behavior in 2.x was to query the $LOAD_PATH when requesting Facts it doesn't know about, but only if querying individual facts or querying all facts when they haven't been cached yet. This can lead to very strange behavior, where different ways of querying facts yield different results. Facter 3.0 made that behavior consistent, but requires Facter.reset when the $LOAD_PATH changes. Add that for cases besides apply and agent, which already do Facter.reset.
Adds an acceptance test ensuring `puppet resource` can find custom facts in `libdir`.
|
I want to clean up the test a bit and verify the factspath(?) setting still works. |
|
👍 for review. Waiting on test update and then will merge. |
Adds testing that factpath is still honored with the fix for PUP-4847. [skip ci]
|
Added testing factpath as a follow-on |
peterhuene
added a commit
that referenced
this pull request
Jul 10, 2015
(PUP-4847) Reset Facter after changing $LOAD_PATH
|
CLA signed by all contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.