(PUP-5075) Check that types that produces caps can use qualified names #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the resolution of declared capability mappings is deferred until all files for a particular environment has been parsed. The commit introduces a new Resource::Type named 'capability_mapping' that acts as intermediate object created by the parser and added to a hash in the known_resource_types TypeCollection which is later made available to the compiler. The compiler uses these objects when it's time to evaluate to perform the actual mapping between capabilities and resources. Once the mapping is complete, the 'capability_mapping' hash is no longer needed and is cleared out to conserve memory.
This commit adds a test that verifies that a resource type that consumes/produces capabilities may have a qualified name.
hlindberg
added a commit
that referenced
this pull request
Aug 28, 2015
…nd-qnames (PUP-5075) Check that types that produces caps can use qualified names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a test that verifies that a resource type that
consumes/produces capabilities may have a qualified name.
This PR sits on top of #4183. The PUP-5075 commit is the only one to consider here.