(PUP-5088) Ensure only => can be used in capability mappings #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| *=> $hostname | ||
| } | ||
| MANIFEST | ||
| end.to raise_error(Puppet::ParseError, /The operator '\* =>' in a Block Expression is not supported/) |
There was a problem hiding this comment.
This does not seem right. I think the expression may be derived from BlockExpression and that a label is missing for it?
|
needs a rebase |
thallgren
force-pushed
the
issue/pup-5088/allowed-capability-attribute-operator
branch
from
b80832a
to
acf80b7
Compare
|
Rebased and fixed syntax in test case. |
This commit relaxes that constraint that a CapabilityMapping only can contain an AttributeOperation so that it instead can contain an AbstractAttributeOperation. This was done to prevent a cryptic error message when an AttributesOperation (note the plural) was assigned due to use of *=> operator. The relaxed constraint lets this pass so that it instead can be trapped in the validator where a correct check was already in place.
thallgren
force-pushed
the
issue/pup-5088/allowed-capability-attribute-operator
branch
from
acf80b7
to
f7aabe4
Compare
|
+1, just waiting for checks to clear before merging |
hlindberg
added a commit
that referenced
this pull request
Sep 2, 2015
…lity-attribute-operator (PUP-5088) Ensure only => can be used in capability mappings
thallgren
deleted the
issue/pup-5088/allowed-capability-attribute-operator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit relaxes that constraint that a CapabilityMapping
only can contain an AttributeOperation so that it instead can
contain an AbstractAttributeOperation. This was done to prevent
a cryptic error message when an AttributesOperation (note the
plural) was assigned due to use of *=> operator. The relaxed
constraint lets this pass so that it instead can be trapped
in the validator where a correct check was already in place.