(maint) Add note about comma delimiting supported checksum types #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @MikaelSmith @jtappa |
|
👍 The travis failure is spurious and unrelated to this PR. |
|
👍 |
| @@ -791,7 +791,7 @@ def self.default_diffargs | |||
| :default => ['md5', 'sha256'], | |||
| :type => :array, | |||
| :desc => 'Checksum types supported by this agent for use in file resources of a static | |||
| catalog. Valid types are md5, md5lite, sha256, sha256lite, sha1, sha1lite, mtime, ctime.', | |||
| catalog. Values must be comma-separated. Valid types are md5, md5lite, sha256, sha256lite, sha1, sha1lite, mtime, ctime.', | |||
There was a problem hiding this comment.
Doesn't follow line-wrapping for descriptions elsewhere in the file. Does it matter?
joshcooper
force-pushed
the
maint/master/update-supported_checksum_types-description
branch
from
54486ee
to
860ecd7
Compare
|
@MikaelSmith updated: |
Add note about "Values must be comma-separated" like we do for tags and reports settings.
joshcooper
force-pushed
the
maint/master/update-supported_checksum_types-description
branch
from
860ecd7
to
68402d4
Compare
|
ping @MikaelSmith |
MikaelSmith
pushed a commit
that referenced
this pull request
Feb 8, 2016
…d_checksum_types-description (maint) Add note about comma delimiting supported checksum types
joshcooper
deleted the
maint/master/update-supported_checksum_types-description
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note about "Values must be comma-separated" like we do for tags and
reports settings.