(PUP-5875) Add to_s to Iterator runtime implementation #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the Iterator runtime implementation had no to_s method. This commit adds that so that it prints: "Iterator[T] value" instead of the default and somewhat incomprehensible: "<Puppet::Pops::Types::Iterator:0x007f93ec28f938>" The commit also adds some missing tests for Iterable and Iterator to_s methods.
hlindberg
added a commit
that referenced
this pull request
Feb 11, 2016
(PUP-5875) Add to_s to Iterator runtime implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the Iterator runtime implementation had no to_s
method. This commit adds that so that it prints:
"Iterator[T] value"
instead of the default and somewhat incomprehensible:
"Puppet::Pops::Types::Iterator:0x007f93ec28f938"
The commit also adds some missing tests for Iterable and Iterator
to_s methods.