-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PUP-5122) Add acceptance test for direct puppet running from cache #4666
(PUP-5122) Add acceptance test for direct puppet running from cache #4666
Conversation
/cc @joshcooper @er0ck @seangriff, updated this to use Beaker's tk_helper to modify puppetserver.conf. Has passed running on centos - running it through Windows now. |
ef911e4
to
6a7d1b5
Compare
Update: passed on Windows. Strange note: originally I was running |
created a ticket for the non-exposed --static-catalogs option: |
@@ -0,0 +1,112 @@ | |||
test_name "PUP-5122: Puppet remediates local drift using code_id and content_uri" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @ all
test_names and steps should all have blocks (do end most of the time), moving forward. this helps beaker with indentation and beaker.next with reporting and other user features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@er0ck ah, good to know! Updating now.
db33e18
to
c5a2110
Compare
@er0ck updated steps and test_name with blocks |
file { '#{basedir}/code_id.sh': | ||
ensure => file, | ||
content => "#{code_id_command}", | ||
mode => "0700", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes the user that puppet is running as (via beaker) is the same as what puppetserver
is running as. I'm not sure if that'll be an issue for PE and pe-puppet? May want to relax to 0755.
This commit adds the skeleton of an acceptance test for the scenario where the server tells the agent to run from its cached catalog and remediates local drift to file content. Once further work has been done on actually retrieving file content using content_uri (PUP-5114), this test will be expanded.
c5a2110
to
4a2c30f
Compare
@joshcooper ah, makes sense. Updated with relaxes perms. |
👍 |
…et_cache (PUP-5122) Add acceptance test for direct puppet running from cache
I made a note in https://tickets.puppetlabs.com/browse/PUP-5114 that we'll want to update this test once the agent is using content_uri to retrieve versioned file content. |
This commit adds the skeleton of an acceptance test for the scenario
where the server tells the agent to run from its cached catalog and
remediates local drift to file content.
Once further work has been done on actually retrieving file content
using content_uri (PUP-5114), this test will be expanded.