(PUP-6318) Add --no-batch-files option to install.rb #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonaldseanp
changed the title
mcdonaldseanp
force-pushed
the
RE-7020/remove_batch_redirects
branch
from
0331e16
to
f3cace4
Compare
|
CLA signed by all contributors. |
puppet-agent carries the batch files for all executables with the new move to vanagon for windows projects, we will need an option to omit batch file creation during installation of puppet so there are not more than one set of batch files. So this commit adds a --no-batch-files option for cmake that omits those files.
mcdonaldseanp
force-pushed
the
RE-7020/remove_batch_redirects
branch
from
f3cace4
to
5fc38e8
Compare
|
👍 assuming this has been tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppet-agent carries the batch files for all executables with the new move to
vanagon for windows projects, we will need an option to omit batch file
creation during installation of puppet so there are not more than one set of
batch files. So this commit adds a --no-batch-files option for cmake that omits
those files.