Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Add SUITE_VERSION notes #5411

Merged

Conversation

Iristyle
Copy link
Contributor

@Iristyle Iristyle commented Dec 6, 2016

Add inline docs so that it's clear the purpose of the SUITE_VERSION environment variable relative to the SHA environment variable.

Update the acceptance test README with info on how to run package based acceptance tests.

Feedback requested from @puppetlabs/puppet-maintainers / @puppetlabs/agent-platform-team

Relates to voxpupuli/beaker#1286 that clarifies install_puppet_agent_dev_repo_on

Originally entered Beaker codebase in 2c44004 as part of PUP-4757

 - SUITE_VERSION is important when running local Beaker tests against
   packages.

 - Rewrite the acceptance test `Packages` docs since the rake task is
   `ci:test:aio` and not `ci:test:packages`.  Also update the command
   line parameters that should be pasesd now that beaker-hostgenerator
   is in use.

   I'm sure there are other incorrect things in this documentation,
   but the current concern was around how to run package based
   acceptance locally.

 - A future commit will move the acceptance docs to a better place so
   that they have a better chance of being updated.
@puppetcla
Copy link

CLA signed by all contributors.

@er0ck er0ck merged commit 49cf1fd into puppetlabs:LTS-1.7 Dec 6, 2016
@er0ck
Copy link
Contributor

er0ck commented Dec 6, 2016

and merged up to stable (89b724d) and master (5bb9a7b)

@Iristyle Iristyle deleted the maint/lts-1.7/add-SUITE_VERISON-notes branch April 11, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants