(#12881) Fix cron type default name error on windows #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows I ran into this error with the cron type:
Without this patch, the problem appears to be that the cron type name
parameter defaults to the following block:
On windows
Etc.getpwuid(Process.uid)
returnsnil
. This patch fixesthe problem by binding the object returned by
Etc.getpwuid(Process.uid)
to a variable. We then check if thevariable responds to the
name
method, and only send a message to nameif so. Otherwise, we return "root"
The included spec test will fail if there is a regression in the desired
behavior. The expected failure looks like: