(PUP-8197) Make parameters optional #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task metadata specification says every field in metadata should have a reasonable default so they can be omitted. For parameters that's equivalent to not having metadata, i.e. any input is allowed. Update the task loader to make parameters an optional property.
|
Still picking up a bad commit title from |
|
CLA signed by all contributors. |
|
Needs a test |
|
Are there any existing task instantiator tests, or am I starting from scratch? |
|
merging this and following up with a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task metadata specification says every field in metadata should have
a reasonable default so they can be omitted. For parameters that's
equivalent to not having metadata, i.e. any input is allowed. Update the
task loader to make parameters an optional property.