(PUP-2838) Fix invalid .dot files due to missing escapes of quoted strings in resource names #6848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduce a few failing unit tests related to quotes esaping in dot graph generation. Puppetlabs's postgresql module produce a lot of resources named this way, making graph generation failing with a message similar to: Error: /var/puppet/state/graphs/relationships.dot: syntax error in line 5765 near '"'
|
Can one of the admins verify this patch? |
The warnings check fails because of a bunch of problems in the changed files: ``` warning: parentheses after method name is interpreted as an argument list, not a decomposed argument ```
|
CLA signed by all contributors. |
|
Thanks for also taking the time to clean up the warnings unrelated to the dot issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using resource names with quotes, the
--graphfunctionality of puppet produce a broken dot file:The puppetlabs/puppetlabs-postgresql generates a lot of such resources.
This Pull-Request workaround the problem by escaping quotes when generating the dot graph. A better fix strategy is described in the existing code, unfortunately I can't afford it 馃槃:
puppet/lib/puppet/external/dot.rb
Line 207 in f010459