(#14136) Emit debug/warnings when Augeas provider fails to load files #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The messages and information from /augeas//error are now printed to debug when the provider opens Augeas, allowing file parse errors to be found. The provider can also restrict the files that are loaded (from the default of everything). In these cases, the provider now emits a warning and then prints all the detailed information to debug. Since a few parse errors are common, no warning is given when these optimisations aren't in use.
|
Is there anything I can provide to help somebody review this? Explanations, examples etc. |
|
Targeted to 3.x now in pull request #879. |
zaphod42
added a commit
that referenced
this pull request
Jun 26, 2012
…into 3.0rc (#14136) Emit debug/warnings when Augeas provider fails to load files Originally submitted as #733 against master, re-targeting to 3.x now the branch exists. The messages and information from /augeas//error are now printed to debug when the provider opens Augeas, allowing file parse errors to be found. The provider can also restrict the files that are loaded (from the default of everything). In these cases, the provider now emits a warning and then prints all the detailed information to debug. Since a few parse errors are common, no warning is given when these optimisations aren't in use. Conflicts: CHANGELOG lib/puppet/provider/augeas/augeas.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messages and information from /augeas//error are now printed to debug when
the provider opens Augeas, allowing file parse errors to be found.
The provider can also restrict the files that are loaded (from the default of
everything). In these cases, the provider now emits a warning and then prints
all the detailed information to debug. Since a few parse errors are common, no
warning is given when these optimisations aren't in use.
http://projects.puppetlabs.com/issues/14136