(PUP-10319) Invalidate rubygems cache after uninstalling puppet_gem package #8009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
alexjfisher
force-pushed
the
PUP-10319
branch
from
8ff46de
to
f38a659
Compare
joshcooper
reviewed
Feb 28, 2020
|
CLA signed by all contributors. |
|
jenkins please test this |
jtappa
reviewed
Mar 16, 2020
gimmyxd
reviewed
Mar 20, 2020
| it 'should invalidate the rubygems cache' do | ||
| @gem_source = double('gem_source') | ||
| allow(Puppet::Util::Autoload).to receive(:gem_source).and_return(@gem_source) | ||
| expect(described_class).to receive(:execute_gem_command).with(provider_gem_cmd, %w{uninstall --executables --all myresource}).and_return('') |
There was a problem hiding this comment.
Not sure this expect is needed as it is alos tested on :61
There was a problem hiding this comment.
Without this line, builds were failing with Provider puppet_gem package command 'gem' does not exist on this host
There was a problem hiding this comment.
Yes, sorry i didn't see that this line is also returning something
It is ok like this 👍
|
My update isn't passing in CI (but still works for me locally). Sorry for the noise whilst I try to figure out which change broke it. |
…ackage Without this patch after a gem is uninstalled from puppet's ruby environment using the `puppet_gem` `package` provider other actions in an agent's run fail. For instance, modifying a file fails whilst trying to back it up. eg. ``` Error: Could not back up /some/file: pid: 21277 nil spec! included in [#<Gem::StubSpecifi... --- SNIP (massive array ommitted) --- ] /opt/puppetlabs/puppet/lib/ruby/2.5.0/rubygems/specification.rb:743:in `_all' /opt/puppetlabs/puppet/lib/ruby/2.5.0/rubygems/specification.rb:1153:in `latest_specs' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/rubygems.rb:44:in `directories' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/autoload.rb:142:in `gem_directories' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/autoload.rb:172:in `search_directories' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/autoload.rb:98:in `get_file' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/autoload.rb:62:in `load_file' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/autoload.rb:201:in `load' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/instance_loader.rb:51:in `loaded_instance' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/indirector/terminus.rb:112:in `terminus_class' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/indirector/indirection.rb:366:in `make_terminus' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/indirector/indirection.rb:140:in `terminus' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/indirector/file_bucket_file/selector.rb:16:in `get_terminus' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/indirector/file_bucket_file/selector.rb:20:in `head' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/indirector/indirection.rb:260:in `head' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/file_bucket/dipper.rb:48:in `backup' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/backups.rb:82:in `backup_file_with_filebucket' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/backups.rb:28:in `perform_backup_with_bucket' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/backups.rb:15:in `perform_backup' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type/file.rb:1024:in `backup_existing' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type/file.rb:761:in `remove_existing' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type/file.rb:888:in `write' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type/file/data_sync.rb:93:in `contents_sync' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/type/file/content.rb:136:in `sync' --- SNIP --- ``` This commit is inspired by puppetlabs@b61fa20 (puppetlabs#2415)
gimmyxd
approved these changes
Mar 24, 2020
joshcooper
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch after a gem is uninstalled from puppet's ruby
environment using the
puppet_gempackageprovider other actions inan agent's run fail. For instance, modifying a file fails whilst trying
to back it up.
eg.
This commit is inspired by
b61fa20
(#2415)