Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUP-4138) Add compiler PCP metrics #168

Merged
merged 1 commit into from May 12, 2023

Conversation

m0dular
Copy link
Collaborator

@m0dular m0dular commented May 11, 2023

This commit adds the config needed to collect PCP broker service metrics from compilers. It also removes some spurious queries from some of the Grafana panels. Not sure how those ended up there or what effect they're having, but they aren't needed.

This commit adds the config needed to collect PCP broker service metrics
from compilers.  It also removes some spurious queries from some of the
Grafana panels.  Not sure how those ended up there or what effect
they're having, but they aren't needed.
@m0dular m0dular requested a review from a team as a code owner May 11, 2023 22:18
@m0dular
Copy link
Collaborator Author

m0dular commented May 11, 2023

Needs the fix from puppetlabs/influxdb#82

Copy link
Contributor

@elainemccloskey elainemccloskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested on 2021.7.3 and LGTM

@MartyEwings MartyEwings merged commit e16ddb3 into puppetlabs:main May 12, 2023
22 of 27 checks passed
@MartyEwings MartyEwings added the enhancement New feature or request label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants