Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDB-1102) Upgrade to activemq 5.10.1 #1231

Closed
wants to merge 1 commit into from
Closed

(PDB-1102) Upgrade to activemq 5.10.1 #1231

wants to merge 1 commit into from

Conversation

rbrw
Copy link
Contributor

@rbrw rbrw commented Jan 27, 2015

No description provided.

@rbrw rbrw force-pushed the ticket/master/pdb-1102-upgrade-activemq branch from f735be4 to 25ec4e5 Compare January 27, 2015 22:57
@pljenkinsro
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/479/

@senior
Copy link
Contributor

senior commented Jan 28, 2015

@pljenkinsro retest this please

@kbarber kbarber added the work in progress (...and please don't merge) label Jan 28, 2015
@pljenkinsro
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/486/

@rbrw rbrw added work in progress (...and please don't merge) and removed work in progress (...and please don't merge) labels Jan 28, 2015
@rbrw
(PDB-1102) Upgrade: activemq (5.10.1) jmx (0.3.0)
c7f2e5b 
Upgrade activemq, and upgrade clojure.jmx along with it it to fix a
problem converting nil values to JSON.  Without the jmx upgrade we had:

  $ curl -X GET http://localhost:8080/metrics/v1/mbeans/org.apache.activemq:type=Broker,brokerName=localhost,destinationType=Queue,destinationName=puppetlabs.puppetdb.commands \
  | grep SlowConsumerStrategy
  "SlowConsumerStrategy" : "java.lang.IllegalArgumentException: No implementation of method: :objects->data of protocol: #'clojure.java.jmx/Destract found for class: nil",

After the upgrade we have:

  "SlowConsumerStrategy" : null,
@rbrw rbrw force-pushed the ticket/master/pdb-1102-upgrade-activemq branch from 25ec4e5 to c7f2e5b Compare January 29, 2015 19:59
@pljenkinsro
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/498/

@rbrw
Copy link
Contributor Author

rbrw commented Jan 29, 2015

@pljenkinsro retest this please

@pljenkinsro
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/503/

@rbrw rbrw added work in progress (...and please don't merge) and removed work in progress (...and please don't merge) labels Jan 30, 2015
@rbrw
Copy link
Contributor Author

rbrw commented Feb 2, 2015

@senior ran in to intermittent failures, which I can corroborate. Running "lein test" failed one time out of 18 here, and then when I let it go further, 6 times out of 28. At least one of the failures looked like this:

Caused by: clojure.lang.ExceptionInfo: throw+: "Results not found after 100 iterations, giving up"
 at puppetlabs.puppetdb.cli.import_export_roundtrip_test$block_until_results_fn.invoke (import_export_roundtrip_test.clj:49)
    puppetlabs.puppetdb.cli.import_export_roundtrip_test$block_on_node$fn__25178.invoke (import_export_roundtrip_test.clj:76)
    clojure.core$binding_conveyor_fn$fn__4145.invoke (core.clj:1910)
    clojure.lang.AFn.call (AFn.java:18)
    java.util.concurrent.FutureTask.run (FutureTask.java:262)
    java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1145)
    java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:615)
    java.lang.Thread.run (Thread.java:745)

@kbarber
Copy link
Contributor

kbarber commented Feb 3, 2015

@rbw @senior out of curiosity, have we tried an older version of amq, to see if this issue can be bisected to a particular new revision by any chance?

@kbarber
Copy link
Contributor

kbarber commented Feb 4, 2015

Or a newer version: http://activemq.apache.org/activemq-5110-release.html

@kbarber
Copy link
Contributor

kbarber commented Feb 11, 2015

Closing this for now, since we're punting this out: https://tickets.puppetlabs.com/browse/PDB-1102

@kbarber kbarber closed this Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
work in progress (...and please don't merge)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rbrw @pljenkinsro @senior @kbarber