(PDB-1342) Fix trusted facts fallback #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| end | ||
| it 'should return trusted data when falling back to the node' do | ||
| # This removes :trusted_information from the global context, triggering our fallback code. | ||
| Puppet.rollback_context('initial testing state') |
There was a problem hiding this comment.
This won't pass on Puppet 3.5.1 it would seem ... the function doesn't exist in that rev.
There was a problem hiding this comment.
Updated and tested against 3.7.1 and latest.
When adding trusted facts, a fallback mechanism is used to pull them from the node object if there aren’t any there already. This code is broken in puppet 4; it’s unclear whether it happened to work in puppet 3 because there was a global request object available or because this code was never called. In any case, the change works in both.
mullr
force-pushed
the
ticket/stable/pdb-1342-fix-trusted-node-data
branch
from
e41b01e
to
f7604f0
Compare
|
Test PASSed. |
kbarber
added a commit
that referenced
this pull request
Mar 30, 2015
…d-node-data (PDB-1342) Fix trusted facts fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding trusted facts, a fallback mechanism is used to pull them
from the node object if there aren’t any there already. This code is
broken in puppet 4; it’s unclear whether it happened to work in puppet 3
because there was a global request object available or because this
code was never called. In any case, the change works in both.