(maint) don't validate package version as semver in status service #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,7 +78,8 @@ | |||
| [puppetlabs/trapperkeeper ~tk-version] | |||
| [puppetlabs/trapperkeeper-webserver-jetty9 ~tk-jetty9-version] | |||
| [prismatic/schema "1.0.4"] | |||
| [puppetlabs/trapperkeeper-status ~tk-status-version :exclusions [trptcolin/versioneer]] | |||
| [puppetlabs/trapperkeeper-status ~tk-status-version] | |||
| [trptcolin/versioneer "0.2.0"] | |||
There was a problem hiding this comment.
might want to put this above the status service since it's a dependency of status
|
@cprice404 does this seem reasonable or should we be fixing the status service to accept SNAPSHOTs? |
wkalt
force-pushed
the
maint/master/dont-validate-package-version-as-semver
branch
from
d858350
to
61c85de
Compare
| @@ -93,6 +94,16 @@ | |||
| true | |||
| @maint-mode-atom)))) | |||
|
|
|||
| (defn get-artifact-version | |||
There was a problem hiding this comment.
I'd make a note in a docstring about how this needs to be fixed upstream in clj-semver
This was causing issues in the extensions tests due to our snapshot versioning.
wkalt
force-pushed
the
maint/master/dont-validate-package-version-as-semver
branch
from
61c85de
to
1da2a17
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
kbarber
added a commit
that referenced
this pull request
Feb 17, 2016
…e-version-as-semver (maint) don't validate package version as semver in status service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing issues in the extensions tests due to our snapshot versioning.