(PDB-5519) Upgrade to honeysql v2 #3703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins tests are failing because the method of pinning honeysql in this PR doesn't work when building an ezbake package. Once we get the update into clj-parent and no longer need the pin, those tests will pass. |
austb
force-pushed
the
upgrade-honeysql-main
branch
4 times, most recently
from
39e24d1
to
b0b19e1
Compare
|
@austb are we ready to get this in? |
|
I had to make some substantive changes to our handling of group by/order handling, so I've been hoping to get @rbrw eyes on it and our PTO has been conflicting for the past weeks. |
|
I think continuing to target 8.x (main) for this change makes sense. Seems risky for 7.x / LTS. |
austb
force-pushed
the
upgrade-honeysql-main
branch
6 times, most recently
from
8ea9147
to
aeb4f6a
Compare
austb
force-pushed
the
upgrade-honeysql-main
branch
2 times, most recently
from
9cc6ab7
to
c78b9cd
Compare
honeysql v1 and v2 can be present in a project simultaneously
Updates many honeysql v1 function calls to their new v2 format. For
example, `(hcore/raw str...)` becomes `[:raw str...]`, `hcore/inline`
becomes `[:inline ...]`, etc. In a few places we need to get the string
out of a SqlRaw type (so we use `:s`), now this is the second field in
an array.
Enable native support for postgresql operators by including
`honey.sql.pg-ops`. Where trivial (and supported by our current
parameter handling), some raws are converted to native honeysql v2
syntax now that their operators are supported natively. Most are left
raw, but honeysql should support all our use-cases natively. Checking
for a raw value is different due to the format change as well.
Update the type coercion matrix. Turning a column into a raw statement
(even the new `[:raw _]` form) is not the "noop" it was being used for
in the type coercion matrix. It causes issues when the coerced type is
used in a selection field because `{:select [^SqlRaw "string"]}` would
become `{:select [[:raw "string"]]}` which compiles as "SELECT raw as
\"string\"" instead of the desired outcome. Instead we use keyword to
"convert" the column into itself. It should be noted that this is _only_
safe due to the fact that we only use type coercion on the column name.
Update `sql-cast` which instead of creating raw SQL calls for the
conversions, uses the built in method of calling functions in honeysql
v2.
`sql-regexp-array-match-v2` is added as the new honeysql v2 version to
avoid making changes to the legacy query engine.
Before, we were compiling paging options manually and tacking them onto the end of a query. Limit and offset will always be an integer, but order by could include honeysql to represent the field that we are grouping by. Honeysql v2 doesn't compile partial expressions, and instead errors. Therefore we instead pass the paging options through with our generated query plan and allow honeysql to create the paging options in the query directly.
hsql v1 allowed for `:modifiers` to specify the distinct query, v2 requires that you use `:select-distinct` instead.
All usage of honeysql v1 has been removed
austb
force-pushed
the
upgrade-honeysql-main
branch
from
c78b9cd
to
24b11ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on puppetlabs/clj-parent#351 which is blocked until after the upcoming release.