Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) modulesync 65530a4 Update Travis #121

Merged
merged 1 commit into from Jan 12, 2018
Merged

(maint) modulesync 65530a4 Update Travis #121

merged 1 commit into from Jan 12, 2018

Conversation

michaeltlombardi
Copy link
Contributor

Iristyle
Iristyle previously requested changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@Iristyle Iristyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I think we have a few straggler updates in here? Not sure if it's because we were out of sync on this project?

@hunner
Copy link
Contributor

hunner commented Jan 12, 2018

Yeah, looks like just msync lag.

@Iristyle Iristyle dismissed their stale review January 12, 2018 23:10

Michael says this is all good in the hood

@Iristyle Iristyle merged commit 4d63f38 into master Jan 12, 2018
@Iristyle Iristyle deleted the msync_MODULES-6339 branch January 12, 2018 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iristyle Iristyle Iristyle approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaeltlombardi @hunner @Iristyle @LukasAud