This repository has been archived by the owner on Sep 24, 2019. It is now read-only.
(MODULES-6339) Remove bundler update from before_install #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the travis.yml template includes a before_install step which upgrades bundler. This was done to solve for an issue where Travis included the default version of bundler for each ruby version in the matrix. Now, however, Travis seems to include the latest compatible version of bundler - at this time, `1.16.0` - and we are upgrading to `1.16.1` which has an incompatibility issue on Travis at this time. This commit removes the now-unneccessary update step and puts the heavy lifting for maintaining a compatible matrix back onto Travis. A downside to this is that we may have future breaks caused by Travis mismanaging their images, but this is a risk we already have. An alternative is to pin to a version ourselves and manage the pinned version over time.
Iristyle
approved these changes
Jan 2, 2018
There was a problem hiding this comment.
+1 to this based on the discussion / investigation that we did.
I would rather Travis be in the position to maintain the images than us use bundler versions out of sync with what Travis is maintaining. I think they've been pretty responsive to such problems, and they have a large number of customers using Ruby workflows like ours.
hunner
added a commit
that referenced
this pull request
Jan 2, 2018
…339-update-travis-config (MODULES-6339) Remove bundler update from before_install
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-iis
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-accounts
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-acl
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-apache
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-apt
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-chocolatey
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-concat
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs-toy-chest/puppetlabs-dism
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-dsc_lite
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-firewall
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-haproxy
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-hocon
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-ibm_installation_manager
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-inifile
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-java
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-java_ks
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-mysql
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs-toy-chest/puppetlabs-netscaler
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-ntp
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-postgresql
that referenced
this pull request
Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-powershell
that referenced
this pull request
Jan 3, 2018
This was referenced Jan 3, 2018
michaeltlombardi
added a commit
to puppetlabs/puppetlabs-registry
that referenced
this pull request
Jan 4, 2018
RandomNoun7
pushed a commit
to RandomNoun7/puppetlabs-iis
that referenced
this pull request
Jan 5, 2018
shawnferry
pushed a commit
to shawnferry/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2018
diogokiss
pushed a commit
to Tradeshift/puppetlabs-postgresql
that referenced
this pull request
Jan 3, 2019
cegeka-jenkins
pushed a commit
to cegeka/puppet-stdlib
that referenced
this pull request
Jul 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the travis.yml template includes a before_install
step which upgrades bundler. This was done to solve for an issue where
Travis included the default version of bundler for each ruby version
in the matrix. Now, however, Travis seems to include the latest
compatible version of bundler - at this time,
1.16.0- and we areupgrading to
1.16.1which has an incompatibility issue on Travisat this time.
This commit removes the now-unneccessary update step and puts the
heavy lifting for maintaining a compatible matrix back onto Travis.
A downside to this is that we may have future breaks caused by Travis
mismanaging their images, but this is a risk we already have. An
alternative is to pin to a version ourselves and manage the pinned
version over time.