MODULES-4247 - Adds support of ProxyPassReverse directive without matching ProxyPass or ProxyPassMatch to apache::vhost #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzmitryv
changed the title
eputnam
requested changes
Jul 1, 2017
There was a problem hiding this comment.
@dzmitryv , thanks for the PR! My one question is, does line 1 of the _proxy template also need to be updated? https://github.com/dzmitryv/puppetlabs-apache/blob/acc640875765dd088d0d7eef8b61c3bfc9dfe7f1/templates/vhost/_proxy.erb#L1
Also, please add a test or two for this.
|
@dzmitryv Is there any movement on this pr? |
|
@david22swan, no. Unfortunately, I'm not sure if I'd be able to finish this PR. |
|
@dzmitryv I'm sorry to hear that. I'll be closing the PR but I hope that, if you ever have the time to continue working on it, you can resubmit it once again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of Apache module (1.11.0) supports ProxyPassReverse directive only as part of ProxyPass or ProxyPassMatch configuration.
ProxyPassReverse directive can also be used in conjunction with the proxy feature (RewriteRule ... [P]) from mod_rewrite, without matching ProxyPass or ProxyPassMatch. This change allows managing ProxyPassReverse on its own by using proxy_pass_reverse parameter of apache::vhost.
https://tickets.puppetlabs.com/browse/MODULES-4247