Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdksync - (feat) - Removal of inappropriate terminology #2083

Closed
wants to merge 1 commit into from
Closed

pdksync - (feat) - Removal of inappropriate terminology #2083

wants to merge 1 commit into from

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented Nov 4, 2020

(feat) - Removal of inappropriate terminology
pdk version: 1.18.0

@pmcmaw pmcmaw requested a review from a team as a code owner November 4, 2020 12:34
@pmcmaw pmcmaw changed the base branch from master to main November 4, 2020 12:34
ekohl
ekohl reviewed Nov 4, 2020
View reviewed changes
types/oidcsettings.pp
@@ -1,4 +1,4 @@
# https://github.com/zmartzone/mod_auth_openidc/blob/master/auth_openidc.conf
# https://github.com/zmartzone/mod_auth_openidc/blob/main/auth_openidc.conf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a 404

@pmcmaw
Copy link
Contributor Author

pmcmaw commented Nov 4, 2020

Thanks @ekohl, it actually turns out I have already complete the work on this module. I have been out of office for a while and forgot as I've a few other things to do before closing out the actual ticket. #2062

Closing as this isn't required. :-)

@pmcmaw pmcmaw closed this Nov 4, 2020
@DavidS DavidS deleted the pdksync_removal_of_inappropriate_terminology branch May 10, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmcmaw @ekohl