New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various major behavioural changes #447
Conversation
* Instead of having 4 options controlling purging we now have a single hash with four possible keys. * We purge everything by default. * `/etc/apt/preferences` is now always managed. * Add missing `mode` to some of the files.
I have not yet had the time to look at the Beaker tests. I expect them to explode phenomenally. |
urgh, sorry, reviewing commit by commit made the inline comments look less readable in the PR :\ |
* Instead of having 4 options controlling purging we now have a single hash with four possible keys. * Include `apt::update` only _after_ we've assembled the `$_update` hash.
* Allow any configuration of apt to be done through data bindings by passing in hashes representing the resources. * Switch apt::ppa to use `distid` as set in `apt::params. This makes `apt::ppa` also work for LinuxMint.
Remove a lot of the redundant `key_` prefixes on `apt::key` and the `keyserver_` prefix on `apt_key`.
Turn `$key` into something that accepts a string or a hash of four keys representing the different options that can be passed on to `apt::key`.
55824e4
to
061bc49
Compare
The behaviour of passing down undef through multiple layers gets fuzzy so for now be explicit about the keyserver. Once Puppet 4 is out and this behaviour has been crystallised and tested we can revisit it.
00cf71d
to
0cb48b0
Compare
The last two commits ought to have come before my commit that does changes to |
It's been a long time - how have you been
Looks good, thanks @daenney Also, I really like what github did apt::key: in your commit messages. |
A set of commits changing a lot of behaviour of apt for the better. I can't do this as separate PR's as some of them depend on each other which would really slow down the process.
For review purposes I suggest having a look at each individual commit or brains might melt.