{DO NOT MERGE}FM-6264 Update rubocop and clean code #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tphoney
force-pushed
the
rubocop_madness
branch
3 times, most recently
from
d2385db
to
9813af7
Compare
tphoney
commented
Jul 18, 2017
| @@ -6,6 +6,10 @@ appveyor.yml: | |||
| docker_sets: | |||
| - set: docker/ubuntu-14.04 | |||
| - set: docker/debian-8 | |||
| extras: | |||
There was a problem hiding this comment.
@DavidS i am unsure of the syntax for extras and .travis does this look sane ?
There was a problem hiding this comment.
@HelenCampbell you will want this in your .sync.yml as well
tphoney
changed the title
tphoney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs review