Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install apt-transport-https on Debian 7 as well #724

Merged
merged 1 commit into from
Nov 13, 2017
Merged

install apt-transport-https on Debian 7 as well #724

merged 1 commit into from
Nov 13, 2017

Conversation

wyardley
Copy link

In my Beaker instance, Debian 78 appears to have apt-transport-https available from updates repo:

root@debian-78-x64:~# apt-cache  show apt-transport-https
Package: apt-transport-https
Source: apt
Version: 0.9.7.9+deb7u7
Installed-Size: 163
Maintainer: APT Development Team <deity@lists.debian.org>
Architecture: amd64
Depends: libapt-pkg4.12 (>= 0.8.16~exp9), libc6 (>= 2.4), libcurl3-gnutls (>= 7.16.2), libgcc1 (>= 1:4.1.1), libstdc++6 (>= 4.1.1)
Description-en: https download transport for APT
 This package enables the usage of 'deb https://foo distro main' lines
 in the /etc/apt/sources.list so that all package managers using the
 libapt-pkg library can access metadata and packages available in sources
 accessible over https (Hypertext Transfer Protocol Secure).
 .
 This transport supports server as well as client authentication
 with certificates.
Description-md5: 3365a6b50bd0e4eef6e176a80c735f43
Tag: admin::package-management, protocol::http, protocol::ssl,
 role::shared-lib, suite::debian
Section: admin
Priority: optional
Filename: pool/main/a/apt/apt-transport-https_0.9.7.9+deb7u7_amd64.deb
Size: 109262
MD5sum: b93e8396183252e8fea3f75d1b493425
SHA1: e3f294c095cea9e04b284d73e735126a9861d84e
SHA256: b5b51a04959d8876c1963d089259342dcaf7df057e9031f0420fd28591252764

@wyardley
Copy link
Author

I guess since 7 is the minimal version supported, if this actually works, the conditional could also just be removed entirely.

@btravouillon
Copy link

The https method already exists in newer distro (apt >= 1.5), thus the apt-transport-https package is not needed. Even if a transitional package exists, I don't believe it's worthwhile to install it on recent distro. We should keep the conditional.

@willmeek willmeek merged commit c99e225 into puppetlabs:master Nov 13, 2017
@willmeek
Copy link

@wyardley Thank you for your contribution, I have merged this into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants