MODULES-10543: only consider lsbdistcodename for apt-transport-https #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not matter if we have *one* older source from (say) jessie or stretch, we could still be running buster or later. The latter is more reliably indicated by the fact than by the provided "release" parameter, which is really just an arbitrary string that does not necessarily match a Debian suite, especially for third-party repositories. I have had a problem with this setting when deploying a "stretch" repository on a "buster" system because I needed to keep MongoDB running (which is gone from buster). The "stretch" line triggered this line, which conflicted with a `ensure_packages` I had elsewhere in our code base, to *remove* the `apt-transport-https` package from buster and later. An alternative implementation might prefer to remove the package unconditionnally if we run a newer release, but I figured I would keep the changes to a minimum.
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
=======================================
Coverage 73.07% 73.07%
=======================================
Files 5 5
Lines 260 260
=======================================
Hits 190 190
Misses 70 70Continue to review full report at Codecov.
|
anarcat
changed the title
|
Thanks, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not matter if we have one older source from (say) jessie or
stretch, we could still be running buster or later. The latter is more
reliably indicated by the fact than by the provided "release"
parameter, which is really just an arbitrary string that does not
necessarily match a Debian suite, especially for third-party
repositories.
I have had a problem with this setting when deploying a "stretch"
repository on a "buster" system because I needed to keep MongoDB
running (which is gone from buster). The "stretch" line triggered this
line, which conflicted with a
ensure_packagesI had elsewhere in ourcode base, to remove the
apt-transport-httpspackage from busterand later.
An alternative implementation might prefer to remove the package
unconditionnally if we run a newer release, but I figured I would keep
the changes to a minimum.