(MODULES-6948) Fix/generate types chocolateyfeature #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltlombardi
changed the title
|
I'm unable to reproduce the original error, but the updated code works, passes CI, and changes no behavior - and includes updates to the tests. I'm inclined to merge on the belief that @rico89 did initial functional testing when they solved the problem. |
Prior to this commit running `puppet generate types` with the Chocolatey module installed led to an erroneous error whilst trying to build the type for `chocolateyfeature`. This was due to a collision over the `features` method. This commit replaces use of the word `features` in the provider for `chocolateyfeature` with `choco_features`, ensures the rest of the relevant code matches, and updates the tests.
ThoughtCrhyme
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix MODULES-6948 with changing the function name from features to choco_features. features is used by puppet internally to match providers and types (has_feature etc.). With renaming the feature function in the chocolateyfeature provider, it prevents this function to be executed when the types are getting generated on the master (and then fails because no chocolatey config can't be found).