Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

choco update is deprecated #283

Closed
chelnak opened this issue Mar 29, 2022 · 0 comments · Fixed by #286
Closed

choco update is deprecated #283

chelnak opened this issue Mar 29, 2022 · 0 comments · Fixed by #286
Assignees
@chelnak
Labels
bugfix

Comments

@chelnak
Copy link

chelnak commented Mar 29, 2022

Describe the Bug

Chocolatey provider issues deprecation warning for update command:

DEPRECATION NOTICE - choco update is deprecated and will be removed or 
 replaced in version 1.0.0 with something that performs the functions 
 of updating package indexes. Please use `choco upgrade` instead.

Expected Behavior

A clear and concise description of what you expected to happen.

Steps to Reproduce

Steps to reproduce the behavior:

Run choco update

Environment

Module Version: 6.0.1
Puppet Version: 8.26.0
OS Name/Version: Windows
Chocolatey v0.12.1 Business

Additional Context

Running Chocolatey V 1.0.0+ you get the following error if trying to run an update:

Could not find a command registered that meets 'update'.

Try choco -? for command reference/help.
@chelnak chelnak added the bugfix label Mar 29, 2022
@chelnak chelnak self-assigned this Apr 6, 2022
chelnak added a commit that referenced this issue Apr 7, 2022
@chelnak
(GH-283) Fix depcrecation error
1727a52 
In situations where the resource described in the manifest includes a
version in it's ensure property and choco v1 or above is installed,
puppet runs would fail. This was happening of an issue where the
version of chocolatey was not being properly derrived by choco_version.

In turn, would cause compiled_choco to return false causing the
module to default to using choco update rather than choco upgrade.

This commit fixes that by ensuring that the choco_version method
returns the correct puppet version.
@chelnak chelnak mentioned this issue Apr 7, 2022
Merged
chelnak added a commit that referenced this issue Apr 7, 2022
@chelnak
(GH-283) Fix deprecation error
a9c3ab1 
In situations where the resource described in the manifest includes a
version in its ensure property and choco v1 or above is installed,
puppet runs would fail. This was happening of an issue where the
version of chocolatey was not being properly derived by choco_version.

In turn, would cause compiled_choco to return false causing the
module to default to using choco update rather than choco upgrade.

This commit fixes that by ensuring that the choco_version method
returns the correct puppet version.
chelnak added a commit that referenced this issue Apr 8, 2022
@chelnak
(GH-283) Fix deprecation error
1ce86e9 
In situations where the resource described in the manifest includes a
version in its ensure property and choco v1 or above is installed,
puppet runs would fail. This was happening of an issue where the
version of chocolatey was not being properly derived by choco_version.

In turn, would cause compiled_choco to return false causing the
module to default to using choco update rather than choco upgrade.

This commit fixes that by ensuring that the choco_version method
returns the correct puppet version.
chelnak added a commit that referenced this issue Apr 8, 2022
@chelnak
(GH-283) Fix deprecation error
1a83f70 
In situations where the resource described in the manifest includes a
version in its ensure property and choco v1 or above is installed,
puppet runs would fail. This was happening of an issue where the
version of chocolatey was not being properly derived by choco_version.

In turn, would cause compiled_choco to return false causing the
module to default to using choco update rather than choco upgrade.

This commit fixes that by ensuring that the choco_version method
returns the correct puppet version.
david22swan added a commit that referenced this issue Apr 8, 2022
@david22swan
Merge pull request #286 from puppetlabs/GH-283-choco_update_is_deprec…
5ce30f9 
…ated

(GH-283) Fix deprecation error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chelnak chelnak

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-283) Fix deprecation error puppetlabs/puppetlabs-chocolatey
1 participant
@chelnak