Refactor RSpec tests

[crazymind1337]

I have rewritten all rspec tests using shared_examples. I have mostly taken the test cases from the old rspecs.

• now every supported operating system from metadata.json is been tested
• introduce shared_examples

I have also made a tiny bugfix which occured while writing the tests and other changes to manifests are only sorting of variables.

[crazymind1337]

I still have to fix rubocop-test.

[codecov-commenter]

Codecov Report

Merging #624 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   27.94%   27.94%           
=======================================
  Files          19       19           
  Lines         680      680           
=======================================
  Hits          190      190           
  Misses        490      490           

Impacted Files	Coverage Δ
...ib/puppet/parser/functions/docker_service_flags.rb	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6666cf...fe07788. Read the comment docs.

[crazymind1337]

I did some final edits after reviewing my own changes.

[crazymind1337]

I am still missing some content => ... tests since I had no good idea how to test epp or erb for whole content.

[sanfrancrisko]

@crazymind1337 Are you still intending to address the Rubocop violations and remove them from the TODO list? If so, we might want to make this PR a draft until it's ready for review?

[crazymind1337]

@crazymind1337 Are you still intending to address the Rubocop violations and remove them from the TODO list? If so, we might want to make this PR a draft until it's ready for review?

Oh, I really forget about that. I have moved all but one of the rubocop_todos to the .rubocop.yaml. I was able to remove one of them completly.

[crazymind1337]

I am wondering why the ubuntu1604 / LitmusAcceptance-test is failing now. Any ideas?

[sanfrancrisko]

Thanks for this PR @crazymind1337 - quite an effort, but very much appreciated. I've been reviewing a bit today, but given the size, it'll likely take another bit of time, but we'll try to get it over the line as soon as we can.

[crazymind1337]

Any progress?

[sanfrancrisko]

@crazymind1337 Apologies for the delay - I have been reviewing and testing your changes and they look good. A few last things I want to do but some other high priority stuff came in and blew everything out of the water - I'll try to get back to this early next week and merged by the end of next week.

[david22swan]

@crazymind1337
Making a quick change to point this PR towards the newly defined default main branch as part of our work to remove inappropriate terminology. Apologies if this is inconvenient in any way.

[crazymind1337]

@crazymind1337
Making a quick change to point this PR towards the newly defined default main branch as part of our work to remove inappropriate terminology. Apologies if this is inconvenient in any way.

I have rebased onto the new default branch.

[sanfrancrisko]

Thanks for your patience @crazymind1337 - I'm rotating on triage from later today, so I'll make your PR the first priority.

[crazymind1337]

Stay calm. No stress please! :D

[crazymind1337]

Wohoo!!