-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RSpec tests #624
Refactor RSpec tests #624
Conversation
I still have to fix |
62050ef
to
ea4d915
Compare
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
=======================================
Coverage 27.94% 27.94%
=======================================
Files 19 19
Lines 680 680
=======================================
Hits 190 190
Misses 490 490
Continue to review full report at Codecov.
|
40e0e25
to
28e6862
Compare
I did some final edits after reviewing my own changes. |
I am still missing some |
@crazymind1337 Are you still intending to address the Rubocop violations and remove them from the |
28e6862
to
a88c6bc
Compare
Oh, I really forget about that. I have moved all but one of the rubocop_todos to the .rubocop.yaml. I was able to remove one of them completly. |
a88c6bc
to
008a021
Compare
I am wondering why the |
008a021
to
fe07788
Compare
fe07788
to
9c009db
Compare
Thanks for this PR @crazymind1337 - quite an effort, but very much appreciated. I've been reviewing a bit today, but given the size, it'll likely take another bit of time, but we'll try to get it over the line as soon as we can. |
Any progress? |
@crazymind1337 Apologies for the delay - I have been reviewing and testing your changes and they look good. A few last things I want to do but some other high priority stuff came in and blew everything out of the water - I'll try to get back to this early next week and merged by the end of next week. |
@crazymind1337 |
9c009db
to
e723749
Compare
I have rebased onto the new default branch. |
Thanks for your patience @crazymind1337 - I'm rotating on triage from later today, so I'll make your PR the first priority. |
Stay calm. No stress please! :D |
Wohoo!! |
I have rewritten all rspec tests using shared_examples. I have mostly taken the test cases from the old rspecs.
I have also made a tiny bugfix which occured while writing the tests and other changes to manifests are only sorting of variables.