(MODULES-7141) Support Sensitive data type #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can be cross-referenced against https://github.com/puppetlabs/puppetlabs-dsc/pull/324/files Might as well also update the code in https://github.com/puppetlabs/puppetlabs-dsc_lite/blob/master/lib/puppet/provider/base_dsc_lite/powershell.rb#L156-L173 |
|
Pending #50 merge to fix appveyor failure |
|
#50 merged |
jpogran
force-pushed
the
MODULES-7141-support-sensitive-type
branch
2 times, most recently
from
9cec679
to
8bd73cb
Compare
This commit ports code added in puppetlabs-toy-chest/puppetlabs-dsc#324 Sensitive was initially added in Puppet 4.6.0 and fully fleshed out by Puppet 4.8.0. This module currently supports a minimum of Puppet 4.7.0 and therefore users should be expected to use Sensitive for password fields (example updated in README). Added new tests for type helpers demonstrating the ability for MSFT_Credential to allow Sensitive.
jpogran
force-pushed
the
MODULES-7141-support-sensitive-type
branch
from
8bd73cb
to
f292f20
Compare
jpogran
changed the title
Iristyle
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of the code in puppetlabs-dsc PR#324 to add Sensitive types to the dsc_lite module.