Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14463 Convert Fixnum into strings. #101

Closed
wants to merge 4 commits into from
Closed

14463 Convert Fixnum into strings. #101

wants to merge 4 commits into from

Commits on Nov 27, 2012

  1. 14463 Convert Fixnum into strings.

    Avert errors like this:
    Parameter dport failed: Munging failed for value 1194 in class dport: can’t convert Fixnum into String
    
    Also, pass along the protocol so Socket can make well informed decisions.
    Sharif Nassar committed Nov 27, 2012
    Copy the full SHA
    2421574 View commit details
    Browse the repository at this point in the history
  2. Fix to pass unit tests.

    * Add default protocol to fix the test for converting a string 'ssh' to a port
    number was failing like so:
      1) Puppet::Type::Firewall dport should convert a port name for dport to its number
         Failure/Error: @resource[port] = 'ssh'
         Puppet::Error:
           Parameter dport failed: Munging failed for value "ssh" in class dport: no such service ssh/proto
         # ./lib/puppet/type/../../puppet/util/firewall.rb:84:in `getservbyname'
         # ./lib/puppet/type/../../puppet/util/firewall.rb:84:in `string_to_port'
         # ./lib/puppet/type/firewall.rb:164:in `unsafe_munge'
         # ./spec/unit/puppet/type/firewall_spec.rb:161
    
    * Always convert the response .to_s
    Sharif Nassar committed Nov 27, 2012
    Copy the full SHA
    b4c00b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2012

  1. Use grown up regex.

    Sharif Nassar committed Nov 28, 2012
    Copy the full SHA
    36a1951 View commit details
    Browse the repository at this point in the history
  2. 14463 Add a UDP lookup test as well.

    Mostly just to get Travis to try again.
    Sharif Nassar committed Nov 28, 2012
    Copy the full SHA
    761f505 View commit details
    Browse the repository at this point in the history