Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a filesystem path to bind #128

Closed
wants to merge 1 commit into from

Conversation

jinty
Copy link

@jinty jinty commented Sep 30, 2014

So you can setup haproxy to listen on a socket. For example:

        haproxy::listen { "listener":
                bind      => {"/path/to/socket" => []}
        }

So you can setup haproxy to listen on a socket
@underscorgan
Copy link

@jinty thanks for the contribution, but this needs documentation and test updates for the new allowed behaviors. Once you make those updates, please squash everything down to a single commit.

@antaflos
Copy link

antaflos commented Mar 5, 2015

Just like the changes in #152 and #143 this change is also moot because the complex and limiting validation code for the $bind parameter has been removed in #154. Specifying a filesystem path in bind is now totally possible and even tested (both in spec tests and in our production systems).

@underscorgan
Copy link

Thanks @jinty , but closing due to @antaflos's comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants