Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable usage of IPv6 addresses #143

Closed
wants to merge 1 commit into from
Closed

Enable usage of IPv6 addresses #143

wants to merge 1 commit into from

Conversation

prtrx
Copy link

@prtrx prtrx commented Jan 8, 2015

With this change IPv6 addresses can be used for frontend/listen bind.

@prtrx
Enable usage of IPv6 addresses
d3a41ec 
With this change IPv6 addresses can be used for frontend/listen bind.
@underscorgan
Copy link

@prtrx Can you please add tests?

@antaflos
Copy link

antaflos commented Mar 5, 2015

This can be closed as well (like #152 was) because #154 completely removed the complex and limiting validation code for IP addresses and ports when using the $bind parameter, making this change moot.

@antaflos antaflos mentioned this pull request Mar 5, 2015
Closed
@underscorgan
Copy link

Thanks @prtrx , but closing per @antaflos's comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prtrx @underscorgan @antaflos