Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to use multiple defaults sections #232

Merged
merged 1 commit into from
Jun 2, 2016

Conversation

vicinus
Copy link

@vicinus vicinus commented Mar 20, 2016

If there is interest in this feature I will add documentation and spec tests. The patch add the option to use multiple defaults section, as described in the haproxy documentation:

A "defaults" section sets default parameters for all other sections following
its declaration. Those default parameters are reset by the next "defaults"
section. See below for the list of parameters which can be set in a "defaults"
section. The name is optional but its use is encouraged for better readability.

It's completely optional. Additionally if defaults are used, then the frontend and backend section are kept together in the haproxy configuration file if the frontend has the option default_backend or the frontend and backend are identical named. We are using multiple defaults and the improved ordering to improve the readability in our very long haproxy configuration files.

@bmjen
Copy link

bmjen commented Mar 23, 2016

@vicinus This is a good start and extension of the haproxy module. And as far as I can tell, it maintains backwards compatibility as well. I'd be on board with moving forward with docs and tests.

/cc @hunner for 2nd opinion

@vicinus
Copy link
Author

vicinus commented Mar 31, 2016

I have added documentation, spec tests and acceptance tests. Please let me know if documentation or spec tests needs to be expanded further.

Also as far as I can tell, the failed checks are not caused due to my changes. One issue is that haproxy::params::merge_options is used as a default value in haproxy::instance without inheriting haproxy::params.

@jonnytdevops
Copy link

@bmjen Does this look good to you now? I managed to re-run the travis/docker build and got it passing.

@bmjen bmjen merged commit 9704689 into puppetlabs:master Jun 2, 2016
cegeka-jenkins pushed a commit to cegeka/puppet-haproxy that referenced this pull request Dec 19, 2017
…ions

add option to use multiple defaults sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants