Re-add support for specifying package version in package_ensure #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restricting haproxy::package_ensure to one of 'present', 'absent' or 'latest' prevents the user from letting Puppet install a specific version of the HAProxy package. This restriction is unwise. It is also an unnecessary breaking change from version 1.5.0. This commit replaces the Enum data type for haproxy::package_ensure and haproxy::instance::package_ensure with the String data type, adds spec tests for setting a specific package version and updates the documentation.
|
Closing and reopening to resolve Travis/bundler issues, this is caused due to https://tickets.puppetlabs.com/browse/MODULES-6339. |
hunner
added a commit
that referenced
this pull request
Jan 12, 2018
Re-add support for specifying package version in package_ensure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricting haproxy::package_ensure to one of 'present', 'absent' or
'latest' prevents the user from letting Puppet install a specific
version of the HAProxy package. This restriction is unwise. It is also
an unnecessary breaking change from version 1.5.0.
This commit replaces the Enum data type for haproxy::package_ensure
and haproxy::instance::package_ensure with the String data type, adds
spec tests for setting a specific package version and updates the
documentation.