(MODULES-8407) Add option to set the service's name #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is being added to support using the software collection for haproxy on CentOS. Before this change both the name of the service being managed and the sysconfig file for the service were incorrect and could not be coaxed into a valid state.
genebean
force-pushed
the
service_name
branch
from
ab5e21f
to
f64ece9
Compare
genebean
changed the title
binford2k
approved these changes
Dec 26, 2018
| @@ -188,6 +194,8 @@ | |||
| $_config_dir = pick($config_dir, inline_template($haproxy::params::config_dir_tmpl)) | |||
| } | |||
|
|
|||
| $instance_service_name = pick($service_name, $instance_name) | |||
|
|
|||
| haproxy::config { $title: | |||
| instance_name => $instance_name, | |||
There was a problem hiding this comment.
Do you need to use your new variable here too?
There was a problem hiding this comment.
Not sure what you are asking @binford2k... this should use the new service_name param's value if its set and, if not, default back to what has been done historically... am I missing something?
|
Just thought I would send a post-holidays ping to see what's next here. |
|
This looks good and has been through an adhoc pipeline, as a result merging. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being added to support using the software collection for haproxy
on CentOS. Before this change both the name of the service being managed
and the sysconfig file for the service were incorrect and could not be
coaxed into a valid state.