Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check of OS for the systemd unitfile #347

Merged
merged 3 commits into from
Jun 13, 2019

Conversation

surprisingb
Copy link

As the systemd.unit man page states on a Debian based OS,
the unit files should be put in /lib/systemd/system instead of /usr/lib/systemd/system, otherwise the module fails on Debian.

Debian based OSs use /lib/systemd/system for systemd unitfile
@lionce
Copy link

lionce commented Apr 18, 2019

Hello @surprisingb ,

Thank your for your contribution. It looks like the unit tests are failing because of trailing whitespace error.

manifests/instance_service.pp - ERROR: trailing whitespace found on line 102
manifests/instance_service.pp - ERROR: trailing whitespace found on line 104
manifests/instance_service.pp - ERROR: trailing whitespace found on line 106

In order to merge your PR, please fix the errors.

@surprisingb
Copy link
Author

Hi @lionce,
sorry for the late reply. I removed the trailing whitespaces, the unit tests should be ok now.
Thanks

@lionce
Copy link

lionce commented May 7, 2019

Hello @surprisingb ,

I ran the acceptance tests through all our testing platforms and they are failing for redhat5, centos5, oracle5 and oracle6 with the same error when it's trying to run the following command: /usr/bin/yum -d 0 -e 0 -y install socat
M2Crypto.SSL.SSLError: tlsv1 alert protocol version

Cheers!

@surprisingb
Copy link
Author

I don't get how is this related to my changes, am I missing something?

@carabasdaniel
Copy link

Hi @surprisingb,

The tests were failing because the branch you are on is ~40 commits behind the current master, but these commits seem to pass on the latest master.
Thank you for your contribution.

@carabasdaniel carabasdaniel merged commit 2c9231d into puppetlabs:master Jun 13, 2019
@surprisingb surprisingb deleted the unitfile-check branch June 14, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants