-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds backend and frontend config sections #37
Conversation
new defined types: haproxy::frontend haproxy::backend haproxy::backend uses haproxy::balancermember the same way haproxy::listen does. I'm not sure I like overloading that, but it should work.
Sorry, didn't realize it was failing in travis. It's better now, though! The trailing comma thing is still ingrained into my brain from perl, and puppet itself is perpetuating that practice for me. Apparently ruby 1.8.7 doesn't like it! |
kinda regretting not making a separate haproxy::backendmember type
@@ -0,0 +1,7 @@ | |||
|
|||
backend <%= name %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this will cause Puppet to issue deprecation warnings, as in Variable access via 'name' is deprecated. Use '@name' instead
, no?
Ok, I'll change all of those here in a little bit. I am pretty sure I just copy/modified those templates, so I think the other ones also have the same issue, but I'll submit a separate PR for that since it's a different change. Thanks for the feedback! Is there anything which would catch these deprecation alerts other than actually performing a puppet run with them? |
I submitted the other deprecation warnings as a separate pr #39 and fixed the ones related to the templates for this feature here. |
adds backend and frontend config sections
adds backend and frontend config sections
new defined types:
haproxy::frontend
haproxy::backend
haproxy::backend uses haproxy::balancermember the same way
haproxy::listen does. I'm not sure I like overloading that, but it
should work.