Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds backend and frontend config sections #37

Merged
merged 6 commits into from
Aug 19, 2013

Conversation

kitchen
Copy link

@kitchen kitchen commented Jun 14, 2013

new defined types:
haproxy::frontend
haproxy::backend

haproxy::backend uses haproxy::balancermember the same way
haproxy::listen does. I'm not sure I like overloading that, but it
should work.

kitchen and others added 2 commits June 14, 2013 15:38
new defined types:
haproxy::frontend
haproxy::backend

haproxy::backend uses haproxy::balancermember the same way
haproxy::listen does. I'm not sure I like overloading that, but it
should work.
@kitchen
Copy link
Author

kitchen commented Jun 16, 2013

Sorry, didn't realize it was failing in travis. It's better now, though!

The trailing comma thing is still ingrained into my brain from perl, and puppet itself is perpetuating that practice for me. Apparently ruby 1.8.7 doesn't like it!

Jeremy Kitchen added 3 commits June 17, 2013 15:16
@@ -0,0 +1,7 @@

backend <%= name %>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will cause Puppet to issue deprecation warnings, as in Variable access via 'name' is deprecated. Use '@name' instead, no?

@kitchen
Copy link
Author

kitchen commented Jun 20, 2013

Ok, I'll change all of those here in a little bit. I am pretty sure I just copy/modified those templates, so I think the other ones also have the same issue, but I'll submit a separate PR for that since it's a different change.

Thanks for the feedback! Is there anything which would catch these deprecation alerts other than actually performing a puppet run with them?

@kitchen kitchen closed this Jun 20, 2013
@kitchen kitchen reopened this Jun 20, 2013
@kitchen
Copy link
Author

kitchen commented Jun 20, 2013

I submitted the other deprecation warnings as a separate pr #39 and fixed the ones related to the templates for this feature here.

hunner added a commit that referenced this pull request Aug 19, 2013
adds backend and frontend config sections
@hunner hunner merged commit f381510 into puppetlabs:master Aug 19, 2013
cegeka-jenkins pushed a commit to cegeka/puppet-haproxy that referenced this pull request Dec 19, 2017
adds backend and frontend config sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants