Allow specifying mapfile entries to be collected later

[yakatz]

This will allow declaring mapfile entries separately and collecting them later.

Example usage:

@haproxy::mapfile::entry { 'example.com dotcom-backend':
    mapfile => 'shared-hosting',
}

haproxy::mapfile { 'shared-hosting':
    ensure   => 'present',
}

Haproxy::Mapfile::Entry <| mapfile == 'shared-hosting' |>

[puppet-community-rangefinder]

haproxy::mapfile is a type

that may have no external impact to Forge modules.

haproxy::mapfile::entry is a type

that may have no external impact to Forge modules.

This module is declared in 40 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[github-actions]

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

[yakatz]

I would appreciate some feedback on why the tests are failing

[petergmurphy]

Hi yakatz,

I've been looking into why your tests are failing. I've rebased your code off upstream/main and made appropriate changes to it on my own fork.

With these changes the acceptance tests are now passing on my local test environment with Ubuntu 20.04 and Puppet 7. If these changes look satisfactory to you, let me know and I can add them to your code.

Peter

[yakatz]

With these changes the acceptance tests are now passing on my local test environment with Ubuntu 20.04 and Puppet 7.

Hi Peter,
The tests pass on my local machine already, but there is something different about the CI environment. I am looking at your changes now.

[yakatz]

With these changes the acceptance tests are now passing on my local test environment with Ubuntu 20.04 and Puppet 7. If these changes look satisfactory to you, let me know and I can add them to your code.

Hi Peter,
It looks like you missed the point of test - there should be a single frontend that selects a backend based on the mapfile.

[yakatz]

Failed test is a litmus:provision error... Everything else passed 🎉

[petergmurphy]

Nice work getting everything passing. I'll get this merged now! 🎉