(Cont 779) Add Support for Puppet 8 / Drop Support for Puppet 6 #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
david22swan
commented
Mar 27, 2023
david22swan
commented
- Includes an update which pins all Rubocop versions to their newest possible version.
david22swan
force-pushed
the
CONT-780/main/puppet_8
branch
9 times, most recently
from
1dc162b
to
107a3a0
Compare
|
Remaining rubocop rules in TODO are being left in place due to time requirements with the Puppet 8 work. |
New Versions: rubocop = 1.48.1 rubocop-performance = 1.16.0 rubocop-rspec = 2.19.0 Also includes the reactivation of all previously disabled Cops
- Layout/ClosingHeredocIndentation - Layout/EmptyLineAfterGuardClause - Layour/HashAlignment
- Lint/RedundantCopEnableDirective - Style/IfUnlessModifier - Style/RedundantRegexpEscape - Style/RedundantStringEscape - Style/RescueStandardError
- Rspec/EmptyLineAfterExample - Rspec/EmptyLineAfterExampleGroup - Style/TrailingCommaHashLiteral
- RSpec/ContextWording - RSpec/ExampleLength - RSpec/MultipleExpectations
- Rspec/MultipleMemorizedHelpers - Rspec/NestedGroups - RspecRepeatedExampleGroupBody - Rspec/RepeatedExampleGroupDescription - Style/MixinUsage
david22swan
force-pushed
the
CONT-780/main/puppet_8
branch
from
0330c25
to
0db7f4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.