Support minus in service names #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the order with which concat fragments of listening services are collected. The previous implementation could result to wrong configuration files. Example: Suppose you have two backend members named lxbrf23, lxbrf24 and the listening services: -demoservice -demoservice-mess -demoservice-mess-it -demoservice-mess-it-even -demoservice-mess-it-even-more The concat fragments will be alphanumerically ordered and will result to a wrong configuration file.
...since current master of puppetlabs-concat breaks tests.
...which recently was introduced to support services with minus in their name.
apenney
pushed a commit
that referenced
this pull request
Nov 18, 2013
Support minus in service names
|
@apenney That was pretty fast, thanks a lot! (btw: you might want to close #36 - see: #36 (comment)) |
resmo
pushed a commit
to swisstxt/puppet-platform-services
that referenced
this pull request
Jan 14, 2014
Introduced by SRF, since we need support for minus in service names in haproxy. For more details take a look at: puppetlabs/puppetlabs-haproxy#60
resmo
pushed a commit
to swisstxt/puppet-platform-services
that referenced
this pull request
Jan 14, 2014
Since puppetlabs merged our pull request (#60): - Switched back to https://github.com/puppetlabs/puppetlabs-haproxy.git - Set submodule haproxy to commit 0d4c50ed56f4fce06b66c04611cebec29f7a37a8 (which is current head of branch master) More information can be found at: puppetlabs/puppetlabs-haproxy#60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the changes from #36 and was rebased on current master. Additionally it updates corresponding rspec examples.