Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to deploy helm v3 #129

Closed
wants to merge 1 commit into from

Conversation

AblionGE
Copy link

fix tests

add unit test for helm_repo

removing helm 3 option in helm init

@puppet-community-rangefinder
Copy link

helm::config is a class

that may have no external impact to Forge modules.

helm::helm_init is a type

that may have no external impact to Forge modules.

helm::params is a class

that may have no external impact to Forge modules.

helm::repo is a type

that may have no external impact to Forge modules.

helm::repo_update is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

codecov-io commented Nov 21, 2020

Codecov Report

Merging #129 (3f06984) into main (94fd36d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #129   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         10      10           
  Lines        259     259           
=====================================
  Misses       259     259           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94fd36d...3f06984. Read the comment docs.

@AblionGE AblionGE marked this pull request as ready for review November 21, 2020 22:04
@AblionGE AblionGE requested a review from a team as a code owner November 21, 2020 22:04
@AblionGE
Copy link
Author

Hi,
I'm back with a new pull request for Helm 3 !
I was not able to run acceptance test due to a vagrant issue...

edomaur
edomaur previously approved these changes Nov 23, 2020
Copy link

@edomaur edomaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems to be clean, and testing deployment of helm3 seems to work as intended.

@daianamezdrea
Copy link
Contributor

Hi @AblionGE ! Thank you for your PR, it looks very nice, IAC team has the Triage day on Monday when I will test your changes! Cheers!

@daianamezdrea daianamezdrea self-assigned this Dec 3, 2020
@daianamezdrea
Copy link
Contributor

Hi @AblionGE, I'm seeing this error on both centos7 and ubuntu 16.04 :
Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, 'split' parameter 'str' expects a String value, got Undef (file: /etc/puppetlabs/code/environments/production/modules/helm/manifests/repo.pp, line: 79, column: 18)
I'm currently looking to see what is happening, thank you for your patience !

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Marc Schaer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@daianamezdrea
Copy link
Contributor

Hi @AblionGE , we have some dependency failures on ubuntu ( I'm currently working in solving the problem) and after this your PR will be tested on a clean base, thank you!

@daianamezdrea
Copy link
Contributor

Hi @AblionGE, we added Github Action for our tests, could you re-base your PR? Thank you!

fix tests

add unit test for helm_repo

removing helm 3 option in helm init

add acceptance test for helm 3
@AblionGE
Copy link
Author

Hello @daianamezdrea , Rebase done but integration testings are not passing. Is my rebase correct ?

@github-actions
Copy link

github-actions bot commented May 2, 2022

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label May 2, 2022
@treydock
Copy link

treydock commented May 2, 2022

I think this PR needs to be redone to fully remove Helm v2 support to simplify the module. Helm v2 has long been EOL.

@github-actions github-actions bot removed the stale label May 3, 2022
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

Hello! 👋

This pull request has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which PRs need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the PR with a comment.

Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants