New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to deploy helm v3 #129
Conversation
helm::config is a classthat may have no external impact to Forge modules. helm::helm_init is a typethat may have no external impact to Forge modules. helm::params is a classthat may have no external impact to Forge modules. helm::repo is a typethat may have no external impact to Forge modules. helm::repo_update is a typethat may have no external impact to Forge modules. This module is declared in 0 of 575 indexed public
|
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 10 10
Lines 259 259
=====================================
Misses 259 259 Continue to review full report at Codecov.
|
18d520a
to
4557029
Compare
Hi, |
4557029
to
3f06984
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems to be clean, and testing deployment of helm3 seems to work as intended.
Hi @AblionGE ! Thank you for your PR, it looks very nice, IAC team has the Triage day on Monday when I will test your changes! Cheers! |
Hi @AblionGE, I'm seeing this error on both centos7 and ubuntu 16.04 : |
Marc Schaer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Hi @AblionGE , we have some dependency failures on ubuntu ( I'm currently working in solving the problem) and after this your PR will be tested on a clean base, thank you! |
Hi @AblionGE, we added Github Action for our tests, could you re-base your PR? Thank you! |
fix tests add unit test for helm_repo removing helm 3 option in helm init add acceptance test for helm 3
3f06984
to
df09f46
Compare
Hello @daianamezdrea , Rebase done but integration testings are not passing. Is my rebase correct ? |
This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days. |
I think this PR needs to be redone to fully remove Helm v2 support to simplify the module. Helm v2 has long been EOL. |
Hello! 👋 This pull request has been open for a while and has had no recent activity. We've labelled it with If you are waiting on a response from us we will try and address your comments on a future Community Day. Alternatively, if it is no longer relevant to you please close the PR with a comment. Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error. |
fix tests
add unit test for helm_repo
removing helm 3 option in helm init