Add support for Helm v3 (continued) #137

treydock · 2020-12-15T13:22:16Z

@AblionGE and @daianamezdrea , this is a continuation of #129 but with some fixes. The main fix is you can't reference class parameters in defined type parameter defaults without ensuring that those classes are defined before the defined type, which isn't always the best as it makes Puppet code dependent on the order things are defined. Instead you have to include the class and then reference the parameters.

Also had to rename the spec file for acceptance as usually rspec expects spec files to end with _spec.rb

Feel free to make my changes in #129 if that's preferable.

puppet-community-rangefinder · 2020-12-15T13:22:38Z

helm::config is a class

that may have no external impact to Forge modules.

helm::helm_init is a type

that may have no external impact to Forge modules.

helm is a class

that may have no external impact to Forge modules.

helm::params is a class

that may have no external impact to Forge modules.

helm::repo is a type

that may have no external impact to Forge modules.

helm::repo_update is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

codecov-io · 2020-12-15T13:26:08Z

Codecov Report

Merging #137 (a1822a0) into main (94fd36d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #137   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         10      10           
  Lines        259     259           
=====================================
  Misses       259     259

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94fd36d...a1822a0. Read the comment docs.

AblionGE · 2020-12-21T10:25:58Z

Thanks @treydock for improving this !

treydock · 2021-01-14T17:52:30Z

Updated pull request to simplify logic on avoiding init and other things when doing Helm v3 because those things are not needed. For this most recent change the Puppet module was adding Kubernetes tiller resources like a ServiceAccount and that's not necessary with Helm v3 so this most recent change avoids unnecessary changes when install Helm v3, which should also reduce the diff size for entire pull request.

CLAassistant · 2021-02-24T17:38:13Z

All committers have signed the CLA.

daianamezdrea · 2021-03-01T08:58:47Z

Hi @treydock, we have some dependency failures on ubuntu ( I'm currently working in solving the problem) and after this your PR will be tested on a clean base, thank you!

daianamezdrea · 2021-03-29T11:43:52Z

Hi @treydock, we added Github Actions for running our tests, can you rebase this PR? Thank you!

fix tests add unit test for helm_repo removing helm 3 option in helm init add acceptance test for helm 3

treydock · 2021-03-29T15:12:33Z

I have rebased

treydock · 2021-03-29T16:05:42Z

@daianamezdrea Is there a way to run integration tests outside Github Actions? Only 1 of the many tests failed and there is no useful output from the failure to tell me what went wrong so I'd like to test things locally but so far attempts to run the bolt commands locally has failed.

daianamezdrea · 2021-06-14T14:42:55Z

Hi @treydock, I was thinking at a way to get this tested and becaue the old way is not working anymore I have a suggestion that could help you:

Clone kream repo, which will help you to spin up a cluster on your Mac/Linux ---> https://github.com/puppetlabs/kream
Follow the commands:
gem install bundler
bundle install
install kubectl (this needs to be applied according with your system)
rake cluster_up
install helm as here: https://github.com/puppetlabs/kream#helm
If you want to use your branch for helm version , go to Puppetfile and add your branch there, like this:
mod 'puppetlabs/helm', :git=> 'https://github.com/puppetlabs/puppetlabs-helm.git', :branch=> 'helm_test'

daianamezdrea · 2021-06-14T14:44:29Z

Please try this and let me know if it works, sorry for my late answer, I was trying to find a good solution for the problem and then I forgot about it, thank you!

puppet-community-rangefinder · 2022-03-02T10:05:23Z

helm_chart_update_flags is a function

Breaking changes to this file MAY impact these 1 modules (near match):

puppetlabs-helm

helm_create_flags is a function

Breaking changes to this file MAY impact these 1 modules (near match):

puppetlabs-helm

helm_delete_flags is a function

Breaking changes to this file MAY impact these 1 modules (near match):

puppetlabs-helm

helm_install_flags is a function

Breaking changes to this file MAY impact these 1 modules (near match):

puppetlabs-helm

helm_ls_flags is a function

Breaking changes to this file MAY impact these 1 modules (near match):

puppetlabs-helm

helm_package_flags is a function

Breaking changes to this file MAY impact these 1 modules (near match):

puppetlabs-helm

helm_repo_add_flags is a function

Breaking changes to this file MAY impact these 1 modules (near match):

puppetlabs-helm

helm_repo_remove_flags is a function

Breaking changes to this file MAY impact these 1 modules (near match):

puppetlabs-helm

helm_repo_update_flags is a function

Breaking changes to this file MAY impact these 1 modules (near match):

puppetlabs-helm

helm::chart is a type

that may have no external impact to Forge modules.

helm::chart_update is a type

that may have no external impact to Forge modules.

helm::create is a type

that may have no external impact to Forge modules.

helm is a class

that may have no external impact to Forge modules.

helm::package is a type

that may have no external impact to Forge modules.

helm::params is a class

that may have no external impact to Forge modules.

helm::repo is a type

that may have no external impact to Forge modules.

helm::repo_update is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

github-actions · 2022-05-02T02:17:32Z

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

treydock requested a review from a team as a code owner December 15, 2020 13:22

treydock force-pushed the pr-129 branch from 93b0845 to e006602 Compare December 15, 2020 13:41

treydock force-pushed the pr-129 branch 2 times, most recently from 8a87cba to f15b92e Compare January 14, 2021 17:59

sanfrancrisko self-assigned this Jan 25, 2021

Marc Schaer and others added 6 commits March 29, 2021 11:12

Add ability to deploy helm v3

2e8717d

fix tests add unit test for helm_repo removing helm 3 option in helm init add acceptance test for helm 3

Fix usage of version

ec66c4b

Spec files must end with _spec.rb

c434473

Avoid unnecessary changes associated with Helm v2 when doing Helm v3

68d6317

Improve how v2 vs v3 flags are passed to Exec

9f5f366

Add kubeconfig parameter for all defined types to better support Helm v3

f745a94

treydock force-pushed the pr-129 branch from a40c1d1 to f745a94 Compare March 29, 2021 15:12

chelnak added the community label Feb 24, 2022

chelnak closed this Mar 2, 2022

chelnak reopened this Mar 2, 2022

github-actions bot added the stale label May 2, 2022

github-actions bot closed this May 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Helm v3 (continued) #137

Add support for Helm v3 (continued) #137

treydock commented Dec 15, 2020

puppet-community-rangefinder bot commented Dec 15, 2020

codecov-io commented Dec 15, 2020 •

edited

AblionGE commented Dec 21, 2020

treydock commented Jan 14, 2021 •

edited

CLAassistant commented Feb 24, 2021 •

edited

daianamezdrea commented Mar 1, 2021

daianamezdrea commented Mar 29, 2021

treydock commented Mar 29, 2021

treydock commented Mar 29, 2021

daianamezdrea commented Jun 14, 2021 •

edited

daianamezdrea commented Jun 14, 2021

puppet-community-rangefinder bot commented Mar 2, 2022

github-actions bot commented May 2, 2022

Add support for Helm v3 (continued) #137

Add support for Helm v3 (continued) #137

Conversation

treydock commented Dec 15, 2020

puppet-community-rangefinder bot commented Dec 15, 2020

helm::config is a class

helm::helm_init is a type

helm is a class

helm::params is a class

helm::repo is a type

helm::repo_update is a type

This module is declared in 0 of 576 indexed public Puppetfiles.

codecov-io commented Dec 15, 2020 • edited

Codecov Report

AblionGE commented Dec 21, 2020

treydock commented Jan 14, 2021 • edited

CLAassistant commented Feb 24, 2021 • edited

daianamezdrea commented Mar 1, 2021

daianamezdrea commented Mar 29, 2021

treydock commented Mar 29, 2021

treydock commented Mar 29, 2021

daianamezdrea commented Jun 14, 2021 • edited

daianamezdrea commented Jun 14, 2021

puppet-community-rangefinder bot commented Mar 2, 2022

helm_chart_update_flags is a function

helm_create_flags is a function

helm_delete_flags is a function

helm_install_flags is a function

helm_ls_flags is a function

helm_package_flags is a function

helm_repo_add_flags is a function

helm_repo_remove_flags is a function

helm_repo_update_flags is a function

helm::chart is a type

helm::chart_update is a type

helm::create is a type

helm is a class

helm::package is a type

helm::params is a class

helm::repo is a type

helm::repo_update is a type

This module is declared in 0 of 578 indexed public Puppetfiles.

github-actions bot commented May 2, 2022

This module is declared in 0 of 576 indexed public `Puppetfiles`.

codecov-io commented Dec 15, 2020 •

edited

treydock commented Jan 14, 2021 •

edited

CLAassistant commented Feb 24, 2021 •

edited

daianamezdrea commented Jun 14, 2021 •

edited

This module is declared in 0 of 578 indexed public `Puppetfiles`.