(CONT-356) Syntax update #543
Merged
+66
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code now compliant with the following rules: relative_classname_inclusion relative_classname_reference parameter_documentation parameter_types top scope facts legacy facts anchor resource
bastelfreak
reviewed
Jan 11, 2023
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
david22swan
requested changes
Jan 12, 2023
david22swan
approved these changes
Jan 24, 2023
alexjfisher
reviewed
Mar 20, 2024
| ) { | ||
| include ::java::params | ||
| contain java::params |
There was a problem hiding this comment.
Not sure why contain here instead of include (considering java::params doesn't declare any resources and only sets variables).
alexjfisher
reviewed
Mar 20, 2024
| @@ -118,12 +118,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| anchor { 'java::begin:': } | |||
| -> package { 'java': | |||
| package { 'java': | |||
| ensure => $version, | |||
| install_options => $package_options, | |||
| name => $use_java_package_name, | |||
| } | |||
| -> class { 'java::config': } | |||
There was a problem hiding this comment.
java::config used to be contained by java with this anchor pattern. Following this change it isn't anymore. Therefore if anyone has any calling code that eg. did a require java or service {'foo': require => 'java'} the configuration of java is now not guaranteed to happen first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code now compliant with the following rules:
relative_classname_inclusion
relative_classname_reference
parameter_documentation
parameter_types
top scope facts
legacy facts
anchor resource