Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch containerd grpc socket to URI #576

Merged
merged 1 commit into from Oct 31, 2022

Conversation

towo
Copy link
Contributor

@towo towo commented Sep 27, 2022

Adjusts the containerd configuration to properly address the containerd socket via URI; fixes deprecation warnings when using crictl on nodes.

@towo towo requested a review from a team as a code owner September 27, 2022 08:48
@david22swan david22swan reopened this Oct 31, 2022
@david22swan
Copy link
Member

Just rekicking tests

Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Integration test failures aren't related to this PR

@GSPatton GSPatton merged commit 2533407 into puppetlabs:main Oct 31, 2022
@deric
Copy link
Collaborator

deric commented Dec 10, 2022

After this change containerd v1.6.6 won't bind to /run/containerd/containerd.sock

ll /run/containerd/containerd.sock*
srw-rw---- 1 root root 0 Dec 10 12:16 /run/containerd/containerd.sock.ttrpc=

logs

Dec 10 12:22:53 s01 containerd[4031907]: time="2022-12-10T12:22:53.244348892Z" level=info msg=serving... address="unix:///run/containerd/containerd.sock.ttrpc"
Dec 10 12:22:53 s01 containerd[4031907]: time="2022-12-10T12:22:53.244415978Z" level=info msg=serving... address="unix:///run/containerd/containerd.sock"
Dec 10 12:22:53 s01 containerd[4031907]: time="2022-12-10T12:22:53.244436657Z" level=info msg="containerd successfully booted in 0.046892s"
Dec 10 12:22:53 s01 containerd[4031907]: time="2022-12-10T12:22:53.414542407Z" level=info msg="Start event monitor"
Dec 10 12:22:53 s01 containerd[4031907]: time="2022-12-10T12:22:53.414601508Z" level=info msg="Start snapshots syncer"
Dec 10 12:22:53 s01 containerd[4031907]: time="2022-12-10T12:22:53.414615324Z" level=info msg="Start cni network conf syncer for default"
Dec 10 12:22:53 s01 containerd[4031907]: time="2022-12-10T12:22:53.414624581Z" level=info msg="Start streaming server"

while it works fine with former configuration:

[grpc]
  address = "/run/containerd/containerd.sock"
...
ll /run/containerd/containerd.sock*
srw-rw---- 1 root root 0 Dec 10 12:23 /run/containerd/containerd.sock=
srw-rw---- 1 root root 0 Dec 10 12:23 /run/containerd/containerd.sock.ttrpc=

@towo crictl warnings should be fixed in /etc/crictl.yaml:

runtime-endpoint: unix:///var/run/containerd/containerd.sock
image-endpoint: unix:///var/run/containerd/containerd.sock

not in containerd config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants